lib: add types to more cockpit-components #21234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
requested changes
Nov 11, 2024
tomasmatus
force-pushed
the
lib-typescript
branch
2 times, most recently
from
2be261c
to
f381d21
Compare
jelly
reviewed
Nov 13, 2024
| import { Button, ButtonProps } from "@patternfly/react-core/dist/esm/components/Button/index.js"; | ||
| import { | ||
| EmptyStateActions, EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateHeader, EmptyStateIcon, | ||
| EmptyStateVariant, EmptyStateIconProps, EmptyStateHeaderProps |
There was a problem hiding this comment.
Very much a nit but nice, is that you can differentiate from type only imports which should not end up in the bundle.
import type { EmptyStateIconProps }
tomasmatus
force-pushed
the
lib-typescript
branch
from
f381d21
to
edbf1b5
Compare
type cockpit-components-empty-state component type cockpit-components-truncate
tomasmatus
force-pushed
the
lib-typescript
branch
from
edbf1b5
to
6d22f95
Compare
jelly
approved these changes
Nov 13, 2024
jelly
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type cockpit-components-empty-state component
type cockpit-components-truncate