lib: python.ts add exception type #21230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exception type to handle cases when spawned python script exits with error.
tomasmatus
force-pushed
the
python-ts-error
branch
from
6d28f73
to
4e7a000
Compare
|
I'm not really sure if the |
|
ok it can be Line 1399 in 9601aee |
jelly
reviewed
Nov 11, 2024
pkg/lib/python.ts
Outdated
|
|
||
| const pyinvoke = ["sh", "-ec", "exec $(command -v /usr/libexec/platform-python || command -v python3) -c \"$@\"", "--"]; | ||
|
|
||
| export interface PythonExitStatus extends BasicError { | ||
| exit_status: number, |
There was a problem hiding this comment.
This can be null?
function ProcessError(options, name) {
this.problem = options.problem || null;
this.exit_status = options["exit-status"];
if (this.exit_status === undefined)
this.exit_status = null;
this.exit_signal = options["exit-signal"];
if (this.exit_signal === undefined)
this.exit_signal = null;
this.message = options.message;
if (this.message === undefined) {
if (this.problem)
this.message = cockpit.message(options.problem);
else if (this.exit_signal !== null)
this.message = cockpit.format(_("$0 killed with signal $1"), name, this.exit_signal);
else if (this.exit_status !== undefined)
this.message = cockpit.format(_("$0 exited with code $1"), name, this.exit_status);
Although seems like a bug? We set it to null if undefined and then do !== undefined this is weird
There was a problem hiding this comment.
Indeed, I have a feeling that it's a bug and instead it should be checking for this.exit_status !== null
`exit_status` won't be undefined as it is set to `null` when checked for undefined for the first time.
cockpituous
reviewed
Nov 12, 2024
| @@ -1407,7 +1407,7 @@ function factory() { | |||
| this.message = cockpit.message(options.problem); | |||
| else if (this.exit_signal !== null) | |||
| this.message = cockpit.format(_("$0 killed with signal $1"), name, this.exit_signal); | |||
| else if (this.exit_status !== undefined) | |||
| else if (this.exit_status !== null) | |||
There was a problem hiding this comment.
This added line is not executed by any test.
jelly
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exception type to handle cases when spawned python script exits with error.