ws: Disable session timeout for --local-session #21212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
force-pushed
the
local-session-reconnect
branch
from
d28b2b9
to
6788f0d
Compare
`curl` just checks the HTML part, but not the websocket bits. Let cockpit-ws listen to the default port 9090, so that our port forwarding works.
Don't kill a `--local-session` on timeout, i.e. after the browser disconnects. While it would be possible to restart the process if a binary is given, it's impossible to do so with `-`, i.e. talking to stdin/out. Spotted in rhinstaller/anaconda-webui#485 (comment)
martinpitt
force-pushed
the
local-session-reconnect
branch
from
6788f0d
to
e67f606
Compare
jelly
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't kill a
--local-sessionon timeout, i.e. after the browserdisconnects. While it would be possible to restart the process if a
binary is given, it's impossible to do so with
-, i.e. talking tostdin/out.
Spotted in rhinstaller/anaconda-webui#485 (comment)