Skip to content

Commit

Permalink
test: Restrict ABRT/reportd tests to Fedora 39/40
Browse files Browse the repository at this point in the history
reportd has been orphaned for some time and got retired from Fedora
rawhide. Stop trying to install it on Fedora > 40 in tmt.

Also flip the OS selection to a positive list, as that's small and will
eventually shrink into nothingness.

[1] https://src.fedoraproject.org/rpms/reportd
  • Loading branch information
martinpitt committed Jul 3, 2024
1 parent 656cc23 commit c4fa007
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
7 changes: 5 additions & 2 deletions test/browser/browser.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,15 @@ if grep -q 'ID=.*fedora' /etc/os-release && [ "$PLAN" = "main" ]; then
# Fedora-only packages which are not available in CentOS/RHEL
# required by TestLogin.testBasic
dnf install -y tcsh
# required by TestJournal.testAbrt*
dnf install -y abrt abrt-addon-ccpp reportd libreport-plugin-bugzilla libreport-fedora
# required by TestTeam
dnf install -y NetworkManager-team
fi

if grep -Eq 'platform:(f39|f40)' /etc/os-release; then
# required by TestJournal.testAbrt*
dnf install -y abrt abrt-addon-ccpp reportd libreport-plugin-bugzilla libreport-fedora
fi

if grep -q 'ID=.*fedora' /etc/os-release && [ "$PLAN" = "storage-basic" ]; then
# required by TestStorageBtrfs*
dnf install -y udisks2-btrfs
Expand Down
12 changes: 6 additions & 6 deletions test/verify/check-system-journal
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import testlib

sleep_crash_list_sel = "#journal-box .cockpit-logline .cockpit-log-message:contains('(sleep) crashed in')"

NO_ABRT = ["debian-*", "ubuntu-*", "fedora-coreos", "rhel*", "centos-*", "arch"]
ABRT_OS = ["fedora-39", "fedora-40"]


class TestJournal(testlib.MachineCase):
Expand Down Expand Up @@ -557,7 +557,7 @@ ExecStart=/bin/sh -c 'sleep 5; for s in $(seq 10); do echo SLOW; sleep 0.1; done
b.wait_visible(journal_line_selector.format("WARNING_MESSAGE"))
b.wait_visible(journal_line_selector.format("INFO_MESSAGE"))

@testlib.skipImage("ABRT not available", *NO_ABRT)
@testlib.onlyImage("ABRT not available", *ABRT_OS)
@testlib.nondestructive
def testAbrtSegv(self):
b = self.browser
Expand Down Expand Up @@ -590,7 +590,7 @@ ExecStart=/bin/sh -c 'sleep 5; for s in $(seq 10); do echo SLOW; sleep 0.1; done
b.click("#abrt-details .pf-v5-c-accordion__toggle:contains('core_backtrace')")
b.wait_visible("#abrt-details .pf-v5-c-accordion__expandable-content.pf-m-expanded dt:contains('signal') + dd:contains('11')")

@testlib.skipImage("ABRT not available", *NO_ABRT)
@testlib.onlyImage("ABRT not available", *ABRT_OS)
@testlib.nondestructive
def testAbrtDelete(self):
b = self.browser
Expand Down Expand Up @@ -621,7 +621,7 @@ ExecStart=/bin/sh -c 'sleep 5; for s in $(seq 10); do echo SLOW; sleep 0.1; done
b.wait_visible(".pf-v5-c-card__title:contains('(sleep) crashed in')")
b.wait_not_present("button.pf-m-danger:contains('Delete')")

@testlib.skipImage("ABRT not available", *NO_ABRT)
@testlib.onlyImage("ABRT not available", *ABRT_OS)
@testlib.nondestructive
def testAbrtReport(self):
# The testing server is located at verify/files/mock-faf-server.py
Expand Down Expand Up @@ -685,7 +685,7 @@ ExecStart=/bin/sh -c 'sleep 5; for s in $(seq 10); do echo SLOW; sleep 0.1; done
b.click(".pf-v5-c-modal-box__footer button:contains('No')")
b.wait_visible("#abrt-reporting .pf-v5-l-split:contains('Report to Cockpit') a[href='https://bugzilla.example.com/show_bug.cgi?id=123456']")

@testlib.skipImage("ABRT not available", *NO_ABRT)
@testlib.onlyImage("ABRT not available", *ABRT_OS)
@testlib.nondestructive
def testAbrtReportCancel(self):
b = self.browser
Expand Down Expand Up @@ -720,7 +720,7 @@ ExecStart=/bin/sh -c 'sleep 5; for s in $(seq 10); do echo SLOW; sleep 0.1; done
b.click("#abrt-reporting .pf-v5-l-split:contains('Report to Cockpit') button:contains('Cancel')")
b.wait_visible("#abrt-reporting .pf-v5-l-split:contains('Report to Cockpit') .pf-v5-l-split__item:contains('Reporting was canceled')")

@testlib.skipImage("ABRT not available", *NO_ABRT)
@testlib.onlyImage("ABRT not available", *ABRT_OS)
@testlib.nondestructive
def testAbrtReportNoReportd(self):
b = self.browser
Expand Down

0 comments on commit c4fa007

Please sign in to comment.