.github: set [no-test] prefix for dependabot PR's

[jelly]

Dependabot sets labels after PR creation so our pull requests tests would run regardless which is a waste of resources.

[martinpitt]

Hmm, that clears the no-test flag from the PR title, but it also needs to be removed from the actual commit when force-pushing. I assume that commit-message: will literally put it into the commit, not just the PR title/description?

[jelly]

Hmm, that clears the no-test flag from the PR title, but it also needs to be removed from the actual commit when force-pushing. I assume that commit-message: will literally put it into the commit, not just the PR title/description?

Yup, should we put in some effort to drop it there too. Re-pushed with a fix for that:

See: jelly#31

[martinpitt]

Thanks! Let's clean up the title handling a bit.

But I must say, this is super ugly. Originally I thought that our API sets the labels right in the "create PR" call -- but that's not actually supported (unlike with creating a PR interactively), and our bots API doesn't do this , it POSTs the new /pull and then labels it. In theory that should cause a race condition with our bots, as tests-scan takes the webhook event into account, not the current state. So 🤔 how does that work for us? In other words, what could dependabot do differently to work for us?

[jelly]

Thanks! Let's clean up the title handling a bit.

But I must say, this is super ugly. Originally I thought that our API sets the labels right in the "create PR" call -- but that's not actually supported (unlike with creating a PR interactively), and our bots API doesn't do this , it POSTs the new /pull and then labels it. In theory that should cause a race condition with our bots, as tests-scan takes the webhook event into account, not the current state. So 🤔 how does that work for us? In other words, what could dependabot do differently to work for us?

No no, when you manually create a PR you can set no-test as a label in the creation screen. But it looks the same indeed cockpit-project/cockpit#19409

For bot workflows we set [no-test].

[martinpitt]

For bot workflows we set [no-test].

Ah, thanks! that clears it up.

[martinpitt]

Ack, thanks!

[jelly]

Also FYI, I had a discussion with @allisonkarlitskaya in Matrix, maybe we should try to improve this a bit by rewriting it into a bots/node-modules-update and tools/node-modules rebase so we can remove the [no-test] title in Python and more easily handle multiple commits.

But eh, that's a lot of work. Let's wait for things to settle first.