Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dependabot for package.json updates #417

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jelly
Copy link
Member

@jelly jelly commented Oct 2, 2023

Pin our devDependencies, as they will now be updated via dependabot in a more controlled fashion.

TIL: this project does not use a node_modules submodule

@jelly jelly marked this pull request as ready for review October 2, 2023 09:51
@jelly jelly marked this pull request as draft October 2, 2023 10:12
@jelly
Copy link
Member Author

jelly commented Oct 2, 2023

TAP version 13
not ok 1 src/test-utils.js > Failed to load the test file with error:
Error [ERR_REQUIRE_ESM]: require() of ES Module /work/bots/make-checkout-workdir/src/test-utils.js from /work/bots/make-checkout-workdir/node_modules/qunit/src/cli/run.js not supported.
Instead change the require of test-utils.js in /work/bots/make-checkout-workdir/node_modules/qunit/src/cli/run.js to a dynamic import() which is available in all CommonJS modules.
    at run (/work/bots/make-checkout-workdir/node_modules/qunit/src/cli/run.js:55:4)
    at Object.<anonymous> (/work/bots/make-checkout-workdir/node_modules/qunit/bin/qunit.js:56:2)
  ---
  message: "should be able to load file"
  severity: failed
  actual: false
  expected: true
  stack:     at Object.<anonymous> (/work/bots/make-checkout-workdir/node_modules/qunit/src/cli/run.js:62:13)
  ...
1..1
# pass 0
# skip 0
# todo 0
# fail 1
make: *** [Makefile:167: check-unit] Error 1

Pin our devDependencies, as they will now be updated via dependabot in a
more controlled fashion.
@jelly jelly marked this pull request as ready for review October 2, 2023 12:38
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@martinpitt martinpitt merged commit 5783a33 into cockpit-project:main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants