Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to f474f0da1c6f723b9f55b4b599b54680 #826

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

Jelle van der Waa (1):
lib: override PatternFly's secondary dark theme behaviour

Martin Pitt (1):
lib: Drop watching in credentials.js

tomasmatus (1):
lib: pam_user_parser.ts add return types

@github-actions github-actions bot added the bot label Nov 7, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to f474f0da1c6f723b9f55b4b599b54680 Makefile: Update Cockpit lib to f474f0da1c6f723b9f55b4b599b54680 Nov 7, 2024
@github-actions github-actions bot force-pushed the cockpit-lib-update-cockpit-lib-20241107-121032 branch from 3645d61 to 3e1c8d4 Compare November 7, 2024 12:10
@tomasmatus
Copy link
Member

tomasmatus commented Nov 7, 2024

@garrett these pixeltest changes don't look right to me:
https://cockpit-logs.us-east-1.linodeobjects.com/pull-826-3e1c8d48-20241107-121048-fedora-40/pixeldiff.html#TestFiles-testBasic-empty-folder-view-dark

so which color is right? I'd assume the upload button is filled with the correct color

@martinpitt
Copy link
Member

@tomasmatus that feels like the same issue as in cockpit-project/cockpit#21220, which is the "lib: override PatternFly's secondary dark theme behaviour" commit pulled in here. That fixed the override from black to mid-gray background, so I'd say this is right -- at least it makes c-files consistent with cockpit.

@martinpitt martinpitt force-pushed the cockpit-lib-update-cockpit-lib-20241107-121032 branch from 3e1c8d4 to 8a9cd98 Compare November 10, 2024 07:39
@martinpitt martinpitt merged commit 4319448 into main Nov 10, 2024
26 checks passed
@martinpitt martinpitt deleted the cockpit-lib-update-cockpit-lib-20241107-121032 branch November 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants