Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image refresh for debian-testing #7033

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented Oct 25, 2024

@github-actions github-actions bot added the bot label Oct 25, 2024
@cockpituous cockpituous changed the title Image refresh for debian-testing WIP: d07aaa67d378: [no-test] Image refresh for debian-testing Oct 25, 2024
@cockpituous
Copy link
Contributor

cockpituous pushed a commit that referenced this pull request Oct 25, 2024
@cockpituous cockpituous force-pushed the image-refresh-debian-testing-20241025-225411 branch from ac17c58 to 8efd3fb Compare October 25, 2024 22:54
@cockpituous cockpituous changed the title WIP: d07aaa67d378: [no-test] Image refresh for debian-testing Image refresh for debian-testing Oct 25, 2024
@cockpituous
Copy link
Contributor

@martinpitt
Copy link
Member

The problem with TestLogin.testBasic is that who is completely broken, and always empty now. Simple reproducer, just ssh in and type who. It's not ssh specific, same happens with a VT login.

The culprit is systemd (256.7-1 -> 256.7-2). It's actually known already: https://bugs.debian.org/1085643 . Apparently coreutils' who command still uses the old utmp, and systemd disables this now as it's not 2038 safe. We only call who during tests, and could move that to loginctl. I'll see how well that works, otherwise I'll do a naughty.

@martinpitt
Copy link
Member

TestPages.testHistory is similar -- there is no more /var/log/lastlog database, we need to consult lastlog2 now.

@martinpitt martinpitt self-assigned this Oct 28, 2024
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 29, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 29, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 30, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 30, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
martinpitt added a commit to cockpit-project/cockpit that referenced this pull request Oct 30, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
@martinpitt martinpitt force-pushed the image-refresh-debian-testing-20241025-225411 branch from 8efd3fb to 309fe78 Compare October 30, 2024 10:16
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@martinpitt martinpitt merged commit 3811abc into main Oct 30, 2024
12 checks passed
@martinpitt martinpitt deleted the image-refresh-debian-testing-20241025-225411 branch October 30, 2024 11:30
SludgeGirl pushed a commit to Nykseli/cockpit that referenced this pull request Nov 12, 2024
Phase out the last login information from cockpit-session. With distributions
moving to lastlog2 [1], we can get that information from the Overview page
directly.

For now, support both sources.

[1] cockpit-project/bots#7033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants