added new blog post, corresponding images, and a new config file #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncludes/figure.liquid"
SchoolGuy
reviewed
Nov 13, 2024
SchoolGuy
reviewed
Nov 13, 2024
SchoolGuy
reviewed
Nov 13, 2024
SchoolGuy
approved these changes
Nov 13, 2024
|
I will get the PR updated as you described. Should be ready by tomorrow. |
SchoolGuy
approved these changes
Nov 14, 2024
|
@sus-admin If you want I would merge this. Or do you want to patch up anything before we merge this PR? |
|
@SchoolGuy go ahead and merge, thanks. I will start working on some PRs for my other guides, I'm very interested in your feedback and how I can help get some more fixes included in a future release. |
|
@sus-admin First feedback is an oversight of mine during the review. I do desire that all commits are signed via GPG. Is that something you can do? |
|
@SchoolGuy I tried to retroactively sign these commits, but not sure if it's valid or not. please merge the PR, or cancel it and I will submit a new one with signed commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.