-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: Add guides to setup Cobbler in libvirt #178
Conversation
da2e63f
to
909b29a
Compare
909b29a
to
c3b748d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to give it another look, these two nitpicks I found so far.
c3b748d
to
ea2c41f
Compare
cf3b9d9
to
612e704
Compare
Thanks for the suggestions @ByteOtter. I would like us to sit down next week and fix these things together. My writing skills are not the best and as such I am deeply dependant on your input and help. |
630e8c3
to
89b6f19
Compare
The first guide works as good as it possibly can atm. The second guide will be extended tomorrow. Edit: Doing this with openSUSE wasn't a good idea it seems. The template is horribly outdated it seems. I will try and fix that after this PR is in with 3.3.4... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over the first article and added some comments. Most of them are simple wording or grammar nitpicks which you can accept at your discretion.
Apart from that I liked the guide generally, though I do have some personal gripes with it.
Some of the steps, while it is clear what to do, do not provide a reason why you do this. What the step is good for and why Cobbler requires it to be done this way. Maybe you could add a couple more sentences here and there to explain why we are doing this.
If these intricacies are already explained elsewhere a link to another article would be great too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over and suggested some annotations. Again, mostly smaller nitpicks here and there about punctuation and wording.
Other than that I like how you expanded the articles, they are much more coherent and easier to follow and understand.
7b9c884
to
8095c9c
Compare
Co-authored-by: Christopher Hock <[email protected]>
8095c9c
to
507e3d2
Compare
This PR aims to add three new posts:
@ycedres ages ago you said that you are interested to have such a setup at home. I would kindly ask you to help me co-author this blog post and check what I described in these posts.