-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations for improving speed #2825
base: master
Are you sure you want to change the base?
Conversation
I'm not sure if this is the best place to report this, here it goes. When I run Cmder with this PR in a clean system (Windows Sandbox), I get an error on the invocation of Initial run
Second run
|
@daxgames Thank you for the great PR, I'm in the process of reviewing it. Excited to merge it soon! |
@DRSDavidSoft Hopefully it works as well for you as it has for me. |
Sync with master
I'm merging this in the development branch for further review. Please use the development branch as a base for any future PRs, I'll review your great changes very soon. Thank you once again! 🤝 |
<value name="ConWnd X" type="long" data="2194"/> | ||
<value name="ConWnd Y" type="long" data="95"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the starting X,Y position be changed?
Why are we getting back to using a development branch we abandonded that practice years ago. |
@daxgames Good for the CI, because GitHub actions can produce compiled versions of branches. I just wanted to keep the master branch "stable" for now. When we merge development back into master eventually, they will contain the same commits. Sorry if it caused any issues |
Optimize for Speed of Launch for Cmd.exe sessions.
Removed duplicate path entry prevention, aka
enhance_path
functionality from%cmder_root%\vendor\init.bat
.%cmder_root%\vendor\init.bat
is now a run once thing that generates%cmder_root%\config\user_init.cmd
.%cmder_root%\config\user_init.cmd
:Is generated from a template,
%cmder_root%\vendor\user_init.cmd.template
, if it does not exist.Deleting the current output file and starting a new
cmd::Cmder
session.Running a powershell script:
Is 3+ times faster than the current
master
branch%cmder_root%\vendor\init.bat
Is esentially hardcoded version of
init.bat
that does everythinginit.bat
does minus autodiscovery of MOST config.path
if/max_depth
command line arg is greater than 1.The below speeds are WITHOUT
/f
with/t
on a virtual box vm running on an older laptop without SSD storage. Modern hardware SHOULD be even fastermaster
-------------------------->more_speed_2 - Initial Run
------------------------------------>After user_init.cmd