Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment/id as object #100

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Experiment/id as object #100

merged 4 commits into from
Jan 6, 2024

Conversation

webtonize
Copy link
Collaborator

Description

This adds an id property to each exported object which holds a JSON object string containing organization, project, resource name and the original id if present. This is done because the id property is uploaded to Log Analytics by PSRule.Monitor and the json can then be parsed in KQL for reporting purposes.

Related Issue

Fix #99

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@webtonize webtonize self-assigned this Jan 6, 2024
Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 6, 2024

Test Results

531 tests  ±0   531 ✅ ±0   12s ⏱️ +3s
185 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0eef35e. ± Comparison against base commit c63cabc.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c63cabc) 99.36% compared to head (0eef35e) 99.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   99.36%   99.44%   +0.07%     
==========================================
  Files          11       11              
  Lines         633      715      +82     
==========================================
+ Hits          629      711      +82     
  Misses          4        4              
Flag Coverage Δ
unittests 99.44% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webtonize webtonize merged commit b21b063 into main Jan 6, 2024
6 checks passed
@webtonize webtonize deleted the experiment/id-as-object branch January 6, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance output for PSRule.Monitor
1 participant