Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): rm_tag for default json #1140

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(hz): rm_tag for default json #1140

wants to merge 1 commit into from

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jun 17, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

解决 rm_tag 无法删除默认的 json tag 的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: rm_tag for default json
zh(optional): 解决 rm_tag 无法删除默认的 json tag 的问题
用户使用 rm_tag=json 的时候,无法删除掉写注解字段的默认 json tag

struct HelloReq {
    1: string Name (api.query="name"); 
}

理论上应该生成如下

type HelloReq struct {
	Name string `thrift:"Name,1" query:"name" `
}

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners June 17, 2024 07:32
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (9162dd1) to head (c299e85).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
+ Coverage    82.75%   82.81%   +0.06%     
===========================================
  Files           98       98              
  Lines        10044    10062      +18     
===========================================
+ Hits          8312     8333      +21     
+ Misses        1241     1238       -3     
  Partials       491      491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant