Prefer ECS::Service.LoadBalancer (Fixes #2206)

ECS::TaskSet.LoadBalancer was being emitted but ECS::Service.LoadBalancer is a superset. This makes the minimal change to keep backward compatibility (although LoadBalancerName should not be used with TaskSet).
cloudtools · Dec 6, 2023 · ae23bee · ae23bee
1 parent bcc7b50
commit ae23bee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/scripts/patches/ecs.py b/scripts/patches/ecs.py
@@ -64,6 +64,11 @@
         "path": "/PropertyTypes/AWS::ECS::TaskSet.AwsVpcConfiguration",
     },
     # backward compatibility
+    {
+        "op": "remove",
+        "path": "/PropertyTypes/AWS::ECS::TaskSet.LoadBalancer",
+    },
+    # backward compatibility
     {
         "op": "move",
         "from": "/PropertyTypes/AWS::ECS::Service.AwsVpcConfiguration",

diff --git a/troposphere/ecs.py b/troposphere/ecs.py
@@ -245,12 +245,13 @@ class DeploymentController(AWSProperty):
 
 class LoadBalancer(AWSProperty):
     """
-    `LoadBalancer <http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskset-loadbalancer.html>`__
+    `LoadBalancer <http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-loadbalancer.html>`__
     """
 
     props: PropsDictType = {
         "ContainerName": (str, False),
         "ContainerPort": (validate_network_port, False),
+        "LoadBalancerName": (str, False),
         "TargetGroupArn": (str, False),
     }