Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gettings started, add $schema directive at the top of files #769

Merged
merged 19 commits into from
Nov 15, 2024

Conversation

osterman
Copy link
Member

@osterman osterman commented Nov 9, 2024

what

  • Remove unimplemented commands
  • $schema directive at the top of files

why

  • Not everyone will have $schema validaton enabled by default in their editor

references

@osterman osterman changed the title Remove invalid references Update gettings started, add $schema directive at the top of files Nov 9, 2024
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Nov 11, 2024
@osterman osterman marked this pull request as ready for review November 11, 2024 17:03
@osterman osterman requested review from a team as code owners November 11, 2024 17:03
@osterman osterman requested review from kevcube, nitrocode and aknysh and removed request for kevcube and nitrocode November 11, 2024 17:03
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 13, 2024
@osterman osterman merged commit 1368b54 into main Nov 15, 2024
29 checks passed
@osterman osterman deleted the dx-improvements branch November 15, 2024 14:49
Copy link

These changes were released in v1.106.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
2 participants