-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom user-agent to a11y scans #62
Conversation
c2f5634
to
794c03c
Compare
9e1c708
to
f8fbc9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I suggested a rename to user agent
to be more semantic.
.cloudgov/manifest.yml
Outdated
@@ -10,6 +10,7 @@ applications: | |||
name: owasp-zap | |||
services: | |||
- pages-((env))-encryption | |||
- headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are creating a custom user-agent
name the service name should be related to user-agent
.
tasks/a11y/header.py
Outdated
if ups["name"] == "headers" | ||
) | ||
|
||
EXTRA_HEADER_VALUE = headers_service["credentials"]["EXTRA_HEADER_VALUE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from EXTRA_HEADER...
to USER_AGENT...
to be semantic.
f8fbc9c
to
1acfa9a
Compare
tasks/a11y/scraper/spider.py
Outdated
@@ -2,6 +2,7 @@ | |||
from scrapy.crawler import CrawlerProcess | |||
from scrapy.linkextractors import LinkExtractor, IGNORED_EXTENSIONS | |||
from scrapy.spiders import CrawlSpider, Rule | |||
from ..header import USER_AGENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong file name from?
1acfa9a
to
f99946d
Compare
Changes proposed in this pull request:
security considerations
Noted elsewhere