Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom user-agent to a11y scans #62

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Sep 30, 2024

Changes proposed in this pull request:

security considerations

Noted elsewhere

@drewbo drewbo force-pushed the chore-custom-spider-header branch 3 times, most recently from c2f5634 to 794c03c Compare September 30, 2024 15:25
@drewbo drewbo changed the title test root ch Add a11y scan headers Oct 3, 2024
@drewbo drewbo changed the title Add a11y scan headers Add custom user-agent to a11y scans Oct 3, 2024
@drewbo drewbo requested a review from a team October 3, 2024 18:20
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I suggested a rename to user agent to be more semantic.

@@ -10,6 +10,7 @@ applications:
name: owasp-zap
services:
- pages-((env))-encryption
- headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are creating a custom user-agent name the service name should be related to user-agent.

if ups["name"] == "headers"
)

EXTRA_HEADER_VALUE = headers_service["credentials"]["EXTRA_HEADER_VALUE"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from EXTRA_HEADER... to USER_AGENT... to be semantic.

@drewbo drewbo requested a review from apburnes October 4, 2024 13:27
@@ -2,6 +2,7 @@
from scrapy.crawler import CrawlerProcess
from scrapy.linkextractors import LinkExtractor, IGNORED_EXTENSIONS
from scrapy.spiders import CrawlSpider, Rule
from ..header import USER_AGENT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong file name from?

@drewbo drewbo merged commit 79c3672 into main Oct 7, 2024
2 checks passed
@drewbo drewbo deleted the chore-custom-spider-header branch October 7, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add header to better manage spider and axe requests
2 participants