Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline to use credhub vars #188

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Deprecate use of S3 credentials file in favor of Credhub

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Credhub is the authorized secret store for Concourse, so updating the pipeline to use Credhub for variables instead of a file improves security and consistency across our pipelines

@markdboyd markdboyd requested a review from a team as a code owner July 8, 2024 20:02
@markdboyd markdboyd merged commit d8850d3 into main Jul 8, 2024
1 check passed
@markdboyd markdboyd deleted the update-pipeline-credhub branch July 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants