Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse vpc for multiple rosa hcp #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mukrishn
Copy link
Collaborator

@mukrishn mukrishn commented Nov 8, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

updated to use correct VPC count and made logic to reuse vpc continuously.

first x clusters use the same VPC based on the given clusters_per_vpc argument.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Signed-off-by: Murali Krishnasamy <[email protected]>
@mukrishn
Copy link
Collaborator Author

@dry923 @morenod ptal

@morenod
Copy link
Collaborator

morenod commented Nov 12, 2024

Can you fix the linters first?

Then lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants