Skip to content

Commit

Permalink
Remove interface - seems to cause more issues
Browse files Browse the repository at this point in the history
Minor reporting improvement
Corrected slurm config file
  • Loading branch information
JonathanCSmith committed Nov 22, 2022
1 parent 2a65eae commit 12c1925
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 0 additions & 2 deletions cluster/slurm.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ def build_slurm_cluster(config: dict):
processes = config.get("processes", 1)
cores = config.get("cores", 1)
memory = config.get("memory", "4GB")
interface = config.get("interface", None)
walltime = config.get('walltime', "01:00:00")
job_extras = config.get("job_extra", [])
job_script_prologue = config.get("env_setup", [])
Expand All @@ -18,7 +17,6 @@ def build_slurm_cluster(config: dict):
processes=processes,
cores=cores,
memory=memory,
interface=interface,
walltime=walltime,
job_extra_directives=job_extras,
job_script_prologue=job_script_prologue
Expand Down
2 changes: 1 addition & 1 deletion image/formats.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def validate_or_enforce_zarr(source: str, save_path: str = None, chunk_formats:
print(os.listdir("."))

if not os.path.isfile(source):
raise ValueError("The source provided was not a valid path.")
raise ValueError("The source provided [" + source + "] was not a valid path.")

# Use the current file's directory to save the new zarr file (if required)
if not save_path:
Expand Down
3 changes: 1 addition & 2 deletions test_data/slurm_execution_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@
"job_extra": [
"--gres gpu:1"
],
"interface": "ib0",
"env_setup": [
"ml Anaconda3",
"conda activate /camp/stp/ddt/workings/smithj1/envs/clijd_dask"
"conda activate /camp/stp/ddt/working/smithj1/envs/clijd_dask"
],
"walltime": "01:00:00"
}

0 comments on commit 12c1925

Please sign in to comment.