Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage meta description tag #131 #138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eclecticexistential
Copy link

Created python script to read and write description: and file name to each file. Script included.

Earthling added 3 commits October 18, 2018 19:22
…dex of the closing ---, copies all of the content after this point, writes the description meta tag info, including title, and then adds the original content back. All files are updated, python code included.
@jmaupetit
Copy link
Member

Hi @eclecticexistential! Thank you for this work. I'll review it quickly.

For reference, this PR addresses issue #131

Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but I have to refuse this contribution as is: the main reason is that I think we should handcraft descriptions instead of guessing them from the post file name.

updateMD.py Outdated
# des = file[11: len(file)-3].replace('-',' ')
# deslab = 'description: {0}\r\n---'.format(des)
# name = './_posts/' + file
# updatedMD(name, deslab)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like core code that must not be commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants