Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types): Enable reordering name fields #4570

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Nov 14, 2024

Description

Introduce new layout prop nameFieldsOrder to enable reversing first name last name rendering for languages that lead with last names.

<ClerkProvider
  appearance={{
    layout: {
      nameFieldsOrder: "reversed",
    },
  }}
>
UserButton

Screenshot 2024-11-15 at 9 32 26 AM

UserProfile

Screenshot 2024-11-15 at 9 33 45 AM

UserProfile/ProfileForm

Screenshot 2024-11-15 at 9 34 12 AM

SignUp

Screenshot 2024-11-15 at 9 35 32 AM

Resolves SDK-1913

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 1e212bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants