fix(clerk-js,clerk-react,chrome-extension): Build and consume packages without remotely hosted code #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without remotely hosted code
🦋 Changeset detectedLatest commit: 9dab906 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!allow-major |
|
!snapshot |
|
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/backend@1.16.3-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/chrome-extension@2.0.0-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/clerk-js@5.34.0-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/elements@0.19.2-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/clerk-expo@2.3.3-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/expo-passkeys@0.0.4-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/express@1.3.13-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/fastify@2.0.15-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/localizations@3.6.3-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/clerk-react@5.15.4-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/clerk-sdk-node@5.0.64-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/tanstack-start@0.4.27-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/testing@1.3.25-snapshot.v82229a2b5efc2b13289f104989759757ba878957 --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tmilewski
commented
Nov 14, 2024
| @@ -20,9 +23,3 @@ export * from './runtime'; | |||
| export * from './url'; | |||
| export * from './web3'; | |||
| export * from './windowNavigate'; | |||
There was a problem hiding this comment.
Removes a number of duplicated exports.
jacekradko
reviewed
Nov 14, 2024
|
!snapshot rhc-beta |
|
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/backend@1.16.3-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/chrome-extension@2.0.0-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/clerk-js@5.34.0-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/elements@0.19.2-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/clerk-expo@2.3.3-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/expo-passkeys@0.0.4-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/express@1.3.13-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/fastify@2.0.15-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/localizations@3.6.3-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/clerk-react@5.15.4-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/clerk-sdk-node@5.0.64-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/tanstack-start@0.4.27-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/testing@1.3.25-rhc-beta.v9dab906166f584529bf54880bc8daa910511316b --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes remotely hosted code (RHC) for Browser Extensions in the following fashion:
clerk-jsRemoves RHC via
__BUILD_DISABLE_RHC__and creates a new build under@clerk/clerk-js/no-rhc.clerk-reactIntroduces
__BUILD_DISABLE_RHC__into theclerk-reactbuild which, if unset, defaults tofalse.clerk-reactis bundled intochrome-extensionand in that process__BUILD_DISABLE_RHC__is set totruewhich ultimately removes the RHC.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change