Fix incorrect handling of double quotes in stringify
function in CKEditor inspector.
#190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Transform all single quotes passed to
stringify
function instead of only the first one.Additional information
It looks like handling of
"
characters is broken instringifySingleToDoubleQuotesReplacer
, as it produces invalid JS code like this one:using
replaceAll
changes it to:Which is still wrong because
"
are nested inside"
character. I changed it to:Which looks better.