Add support for Light MLS #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhasHere
approved these changes
Nov 3, 2024
bifurcation
commented
Nov 4, 2024
cmd/interop/src/mls_client_impl.cpp
Outdated
Comment on lines
1065
to
1067
| const auto force_path = request->force_path(); | ||
| const auto inline_tree = !request->external_tree(); | ||
| const auto include_membership_proof = false; |
There was a problem hiding this comment.
Looking at this, we haven't updated this code since we moved to AnnotatedWelcome. I'll update and request re-review.
suhasHere
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in draft-kiefer-mls-light-01.
This PR enables clients to join and participate in groups without having the full ratchet tree. There are a few major changes:
mls_dslibrary is added for tools that are useful in constructing a DS. In particular, a class that follows the evolution of a group's ratchet tree based on the Commits in the group