Fix Windows hang in testing #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I think the mystery is resolved here. I will work on getting the Catch2 change merged, then land this one. |
bifurcation
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a recent upgrade to the
windows-latestimage, Windows CI builds have been hanging when running certain tests. This turns out to be due to an error in the way MSVC implements "empty base optimization", which breaks theoverloadedtechnique for ad-hoc polymorphic lambdas -- simply defining one results in stack corruption. While Microsoft claims to have fixed this bug, and GitHub claims to use a version that has the fix, the bug still manifests. This PR adds a work-around that ensures that anoverloadedtype always has at least one member.