responding to @suhasHere comments. Thank you!

cisco · Aug 28, 2023 · 6417880 · 6417880
1 parent 0ecf80b
commit 6417880
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/include/mls/credential.h b/include/mls/credential.h
@@ -188,7 +188,7 @@ struct CredentialBinding
 
   bool valid_for(const SignaturePublicKey& signature_key) const;
 
-  TLS_SERIALIZABLE(credential, credential_key, signature)
+  TLS_SERIALIZABLE(cipher_suite, credential, credential_key, signature)
 
 private:
   bytes to_be_signed(const SignaturePublicKey& signature_key) const;

diff --git a/lib/hpke/src/base64.cpp b/lib/hpke/src/base64.cpp
@@ -16,6 +16,8 @@ to_base64(const bytes& data)
   }
 
   const auto data_size = static_cast<int>(data.size());
+
+  // base64 encoding produces 4 characters for every 3 input bytes (rounded up)
   const auto out_size = (data_size + 2) / 3 * 4;
   auto out = bytes(out_size + 1); // NUL terminator