Add default equality operators #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichLogan
force-pushed
the
default-equality
branch
from
60ab9c2
to
504a62e
Compare
|
Mygdonus isn't going to be able to move to C++20 for a while yet |
paulej
approved these changes
Nov 7, 2023
| @@ -162,11 +194,15 @@ namespace gs | |||
| Loc1 scale; | |||
| Boolean active; | |||
| std::optional<ObjectID> parent; | |||
|
|
|||
| bool operator==(const Object1 &other) const = default; | |||
There was a problem hiding this comment.
Is there a reason this one (and a couple of others) use operator== and the most use operator<=>?
There was a problem hiding this comment.
I had some issues with <=> not being defined on std::optional or std::vector (which might vary by implementation?), so for the types using those I just stuck with the equality that I needed.
| @@ -11,7 +11,7 @@ add_library(gse | |||
|
|
|||
| set_target_properties(gse | |||
| PROPERTIES | |||
| CXX_STANDARD 17 | |||
| CXX_STANDARD 20 | |||
There was a problem hiding this comment.
Is everyone dependent on this code OK with the move to C++20?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds C++20 equality/spaceship default operators.