Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cell: Add DecorateAll for decorating everywhere #24

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Nov 6, 2024

Add the ability to decorate a type in all scopes. This is sometimes useful when one needs to swap out a value or implementation coming from a cell that one doesn't control.

Add the ability to decorate a type in all scopes. This is sometimes
useful when one needs to swap out a value or implementation coming
from a cell that one doesn't control.

Signed-off-by: Jussi Maki <[email protected]>
@joamaki joamaki marked this pull request as ready for review November 6, 2024 19:04
@joamaki joamaki requested a review from a team as a code owner November 6, 2024 19:04
@joamaki joamaki requested review from bimmlerd and removed request for a team November 6, 2024 19:04
@joamaki
Copy link
Contributor Author

joamaki commented Nov 6, 2024

Any suggestions for a better name for this?

Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

re naming: didn't come up with great ideas: DecorateGlobally (meh), DecorateEverywhere (also meh), WrapAll, ..., ReplaceAll - I'm not married to Decorate though the term is precise.. IDK, naming is hard

@joamaki joamaki merged commit bedf51d into main Nov 7, 2024
1 check passed
@joamaki joamaki deleted the pr/joamaki/decorate-all branch November 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants