script: Add support for interrupts #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
force-pushed
the
pr/joamaki/script-interrupt
branch
from
08504d6
to
031fa4f
Compare
joamaki
commented
Oct 10, 2024
joamaki
force-pushed
the
pr/joamaki/script-interrupt
branch
2 times, most recently
from
b87deb3
to
4d9910d
Compare
In order to implement e.g. "watch" command for StateDB we need to be able to interrupt the command. To do this, we need to be able to catch SIGINT, which requires the ISIG lflag and for that we'll need our own "MakeRaw" function. Additionally to be able to dump the log buffer periodically we add a FlushLog() method. Signed-off-by: Jussi Maki <[email protected]>
To try & show-case the interrupt support in script, change the
events command to show events until interrupted.
Example run:
example % go run . repl
example> hive start
...
example> events
{Reserve of peanut butter sandwiches: 99%}
{Elevator music volume now set to 80%}
{Mission completion: 5%}
^C (interrupted)
example> hive stop
Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/script-interrupt
branch
from
4d9910d
to
08b819f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to interrupt long-running commands. This is needed to implement something like "db watch table" that watches a table for changes until interrupted with ctrl-c.
See commits for more details.
You can try this out with: