Delete campaign from schedule after deleting campaign #1249

DelaunayAlex · 2024-02-05T15:57:50Z

No description provided.

server/src/main/java/com/chutneytesting/campaign/infra/SchedulingCampaignFileRepository.java

nbrouand

Remote state in repository : currentMaxId calculate directly when writing only

beforeEach instead of initSut for test independancy

ui/src/app/modules/campaign/components/campaign-list/campaign-list.component.ts

fix(): Delete campaign from schedule after deleting campaign

0e4d704

DelaunayAlex added the bug Something isn't working label Feb 5, 2024

DelaunayAlex requested review from nbrouand and boddissattva February 5, 2024 15:57

nbrouand reviewed Feb 6, 2024

View reviewed changes

server/src/main/java/com/chutneytesting/campaign/infra/SchedulingCampaignFileRepository.java Outdated Show resolved Hide resolved

nbrouand reviewed Feb 6, 2024

View reviewed changes

DelaunayAlex force-pushed the fix/delete_campaign_schedule_on_campaign_deletion branch from be34d89 to 4242c3f Compare February 6, 2024 11:12

nbrouand reviewed Feb 6, 2024

View reviewed changes

ui/src/app/modules/campaign/components/campaign-list/campaign-list.component.ts Outdated Show resolved Hide resolved

nbrouand previously approved these changes Feb 6, 2024

View reviewed changes

boddissattva previously approved these changes Feb 6, 2024

View reviewed changes

fix(): Fix current index, refacto test with @beforeeach

6d5f93e

DelaunayAlex dismissed stale reviews from boddissattva and nbrouand via 6d5f93e February 7, 2024 13:57

DelaunayAlex force-pushed the fix/delete_campaign_schedule_on_campaign_deletion branch from 4242c3f to 6d5f93e Compare February 7, 2024 13:57

boddissattva approved these changes Feb 7, 2024

View reviewed changes

nbrouand approved these changes Feb 7, 2024

View reviewed changes

nbrouand merged commit eeea65f into master Feb 7, 2024
3 checks passed

nbrouand deleted the fix/delete_campaign_schedule_on_campaign_deletion branch February 7, 2024 15:06

Provide feedback