Fixes id equals to undefined string #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Per README.md id is optional and defaults to undefined [1]. This causes a weird behaviour of string concatenation of undefined and results id's in the format similar to 'undefined-...'. Specifically: * `undefined-wrapper` * `undefined-input` * `undefined-picker-container` * `undefined-picker-container-DatePicker` 2. When using multiple datepicker components on a html page this results in an invalid html because of duplicate `id`s. [1] https://github.com/chronotruck/vue-ctk-date-time-picker#props-api
|
Does this solve this: Cannot read property 'id' of undefined
|
|
I do not really remember this well, but from the description I wrote there back then in 2020 this is not. It's for fixing the issue of creating duplicate id's when we do not define an id. The error you are mentioning seems to indicate that $attrs is undefined. But I still reference $attrs in my code. You could try to do some debugging in the browser about _ctx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per README.md id is optional and defaults to undefined [1]. This causes
a weird behaviour of string concatenation of undefined and results
id's in the format similar to 'undefined-...'.
Specifically:
undefined-wrapperundefined-inputundefined-picker-containerundefined-picker-container-DatePickerWhen using multiple datepicker components on a html page this results in
an invalid html because of duplicate
ids.[1] https://github.com/chronotruck/vue-ctk-date-time-picker#props-api