Fix file_base::append for both create/open for windows stream_file.
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the Windows implementation of file support. Seek to the end of file when opening with flags: 1. append (open existing file) -> OPEN_EXISTING 2. create + append (open existing file or create if the file doesn't exist) -> OPEN_ALWAYS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR didn't resolve the issue completely, so I create this to propose new fixes. The PR only affects
stream_filefor the windows platform.Seek to the end of file when opening with flags:
Tested on Windows 10 22H2 19025.