Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker process name always includes all queues name #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Worker process name always includes all queues name #346

wants to merge 1 commit into from

Conversation

tardypad
Copy link

@tardypad tardypad commented May 9, 2017

This facilitates monitoring of each worker process

this facilitates monitoring of each worker process
@pprkut
Copy link

pprkut commented May 9, 2017

To explain a bit further, we monitor workers based on the queue names they are listening to, making sure that there are workers available for all queues we are monitoring.
These queue names are listed in the process name. However, when the worker is actually running, the queue names are dropped from the process name. This results in our monitoring thinking that there is no worker for this queue anymore, giving us a false positive.
So with this change we make sure that the queue names a worker listens to are always in the process name, independent of the worker status.

@m2mobi-mirror m2mobi-mirror deleted the worker_process_queues_name branch May 16, 2017 13:43
@m2mobi-mirror m2mobi-mirror restored the worker_process_queues_name branch May 17, 2017 15:51
danhunsaker added a commit to resque/php-resque that referenced this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants