Refresh Project #329
Refresh Project #329
Conversation
… when the server is windows and the the PID
|
good day i decided to share this with the comunity, the first thing is the syntax is now the 5.6 (maybe not complete but many things) |
composer.json
Outdated
| @@ -1,14 +1,18 @@ | |||
| { | |||
| "name": "chrisboulton/php-resque", | |||
| "name": "spiritdead/php-resque", | |||
There was a problem hiding this comment.
This change cannot be merged. Always be sure to use a dedicated branch for PRs, and not to commit any changes to a PR branch that you don't intend to submit in the PR itself, as GitHub PRs are per branch, not per change set.
There was a problem hiding this comment.
@danhunsaker sorry, was for upload in the packagist for my projects for use the composer to my github is the only way for apply my fixs, this project is outdated
There was a problem hiding this comment.
im creating a module for Yii2 framework, and i need make updates in this project and in the php-resque-scheduler
lib/Resque/Log.php
Outdated
| @@ -10,8 +10,11 @@ class Resque_Log extends Psr\Log\AbstractLogger | |||
| { | |||
| public $verbose; | |||
|
|
|||
| public function __construct($verbose = false) { | |||
| public $debug; | |||
There was a problem hiding this comment.
Looking at how this is applied, I think this isn't the correct name for this property.
Also, it would probably be better to adjust the existing property ->verbose instead of introducing a new parameter with non-configurable behavior.
I agree that being able to filter log entries would be immensely helpful for daily use. What I propose here, then, is to expand the valid values of the ->verbose property. Retaining the meanings of true and false to mean "everything" and "nothing", respectively, we could additionally support passing an array of PSR-3 log level constants/strings. Any log entry whose level is in the array is displayed; all others are skipped.
One thing to note, however, is that Resque_Log isn't meant to be used in most cases as the actual logger implementation, and will likely be dropped in a future release, in favor of a dependency on the PSR-3 virtual package. It's essentially only included for backwards compatibility while the project moves away from bundling dependencies. So you may wish to abandon this change entirely, in that light, and instead use a more capable PSR-3 logger implementation.
There was a problem hiding this comment.
@danhunsaker i can understand that, was a temporary fix in my personal fork, maybe if is possible we can discuss for make a correct refresh of the project with namespace and more stuff
|
this project need a hard refresh, this need namespaces,traits, baseClass for the worker and extend to create the scheduler worker and the normal worker,ETC and make a merge of the repository php-resque-scheduler and this |
There was a problem hiding this comment.
These changes are too sweeping to review properly, so will not be merged. In future, avoid making changes to both styling and logic in the same commit. Also, in most cases, fixing styling should be its own PR, separate from logic concerns. The less a PR changes, the more likely it is to be merged.
|
my mistake hehe, im creating a stable version of this at the same time working in my module, maybe later i will push more, or create a branch for put this clean |
|
Many of these changes make sense, but cannot be merged at this time. I say this not to discourage you from making them, but to warn you that they will not be made upstream, and perhaps save you the time of trying to maintain this PR. |
|
@danhunsaker no worries, maybe when i finish my module if i can i will rewrite this with namespaces |
with the option debug in the class Resque_Log
for some reason this project not have correctly configured the indentation (tab = 4 spaces)