Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to retrieve all the items of a list #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varvar
Copy link

@varvar varvar commented Dec 31, 2015

HI, I've added a method which can retrieve all the items of a list. For example : all failed queues

@danhunsaker
Copy link
Contributor

I'd do a couple of things to this before expecting a merge. First, most of the Resque methods have more descriptive names than the underlying Redis command, so I'd change the method name to something else that reflects its purpose rather than its internals. Second, I'd make the second two arguments optional, and default them to retrieve the full list. This will increase the added value of such a function.

@danhunsaker
Copy link
Contributor

Other than that, though (and the coding style - spaces between function arguments, please), it looks good here!

danhunsaker added a commit to resque/php-resque that referenced this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants