listunspent and import_addresses API methods #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add listunspent method
| @@ -303,7 +303,6 @@ def get_scriptpubkeys_to_monitor(rpc, config): | |||
| break | |||
| spks_to_monitor.append(spks[0]) | |||
| wal.rewind_one(change) | |||
|
|
|||
There was a problem hiding this comment.
Please remove these irrelevant line changes. Or if you want to refactor then open another PR for them.
| @@ -384,6 +394,7 @@ def handle_query(self, query): | |||
| self._send_response(query, result) | |||
| elif method == "blockchain.estimatefee": | |||
| estimate = self.rpc.call("estimatesmartfee", [query["params"][0]]) | |||
| self.logger.info('estimate: ' + estimate) | |||
There was a problem hiding this comment.
Remove from this PR please, it's irrelevant. Also I think it conflicts with another edit I made recently.
|
Thanks for the PR. Implementing Some thoughts:
Apart from that the PR looks good on reading. Please do the edits I ask then I will test out the PR and most likely merge it. |
chris-belcher
force-pushed
the
master
branch
4 times, most recently
from
0633d2c
to
c28a90f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following API methods: