Fixes for outlook #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jun 9, 2017
| @@ -63,7 +69,7 @@ public void mail(ReadableMap options, Callback callback) { | |||
| if (options.hasKey("body") && !options.isNull("body")) { | |||
| String body = options.getString("body"); | |||
| if (options.hasKey("isHTML") && options.getBoolean("isHTML")) { | |||
| i.putExtra(Intent.EXTRA_TEXT, Html.fromHtml(body)); | |||
| i.putExtra(Intent.EXTRA_TEXT, Html.fromHtml(body).toString()); | |||
There was a problem hiding this comment.
Yes - it doesn't work in Outlook otherwise.
|
@chirag04 Can we please get this merged? |
|
Facing the same issue on my project. Could you please merge this MR. |
MrEliasen
added a commit
to MrEliasen/react-native-mail
that referenced
this pull request
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chirag04
This PR includes fixes for Outlook. Outlook only gets attachments from ACTION_SEND and it also needs the output of Html.fromHtml(body) to return a string.