Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not releated to preprocessor #1416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

drom
Copy link
Member

@drom drom commented Mar 25, 2021

Some tests are wrongly marked as preprocessor tests.

@github-actions
Copy link
Contributor

Compared test results

tool new_failures new_passes added removed not_affected
sv_parser 0 0 0 0 4658
tree_sitter_verilog 0 0 6 0 4558
Icarus 0 0 6 0 4558
Odin 0 0 0 0 4658
YosysSv 0 1 0 0 4921
UhdmVerilator 0 0 0 0 4922
moore 0 0 0 0 4658
Sv2v_zachjs 0 0 0 0 4658
Verilator 6 338 0 0 4578
Verible 0 0 6 0 4558
moore_parse 0 0 0 0 4658
Surelog 0 0 0 0 4922
UhdmYosys 0 0 6 0 4558
Slang 0 0 0 0 4922
Yosys 0 0 0 0 4922
VeribleExtractor 0 0 6 0 4558

@tgorochowik
Copy link
Member

Thanks for the PR!

These types that you are removing were actually added by #498

Maybe it would be better to add a separate test type and use it for those tests? Something like suggested here: #1413

@drom
Copy link
Member Author

drom commented Apr 2, 2021

I am OK with ether solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants