Cookstyle Bot Auto Corrections with Cookstyle 7.30.1 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cookstyle[bot]](https://avatars.githubusercontent.com/in/78849?s=60&v=4){kind=small}
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client. ### Style/TrailingCommaInHashLiteral - **/attributes/default.rb:2**: Put a comma after the last item of a multiline hash. ### Chef/Correctness/ChefApplicationFatal - **/libraries/helpers.rb:77**: Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal (https://docs.chef.io/workstation/cookstyle/chef_correctness_chefapplicationfatal) ### Chef/Style/CommentFormat - **/libraries/packer_builder_provider.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_builder_resource.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_post_processor_provider.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_post_processor_resource.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_provisioner_provider.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_provisioner_resource.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_template_provider.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_template_resource.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_variable_provider.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/packer_variable_resource.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/unit/recipes/default_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/unit/recipes/default_spec.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) ### Chef/Deprecations/UseInlineResourcesDefined - **/libraries/packer_builder_provider.rb:26**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) - **/libraries/packer_post_processor_provider.rb:26**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) - **/libraries/packer_provisioner_provider.rb:26**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) - **/libraries/packer_template_provider.rb:26**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) - **/libraries/packer_variable_provider.rb:27**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) ### Chef/Modernize/WhyRunSupportedTrue - **/libraries/packer_builder_provider.rb:28**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue) - **/libraries/packer_post_processor_provider.rb:28**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue) - **/libraries/packer_provisioner_provider.rb:28**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue) - **/libraries/packer_template_provider.rb:28**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue) - **/libraries/packer_variable_provider.rb:29**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue) ### Chef/Deprecations/ResourceUsesOnlyResourceName - **/libraries/packer_builder_resource.rb:21**: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Make sure to use both `resource_name` and `provides` to change the name of the resource. You can also omit `resource_name` entirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename) - **/libraries/packer_post_processor_resource.rb:23**: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Make sure to use both `resource_name` and `provides` to change the name of the resource. You can also omit `resource_name` entirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename) - **/libraries/packer_provisioner_resource.rb:21**: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Make sure to use both `resource_name` and `provides` to change the name of the resource. You can also omit `resource_name` entirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename) - **/libraries/packer_template_resource.rb:21**: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Make sure to use both `resource_name` and `provides` to change the name of the resource. You can also omit `resource_name` entirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename) - **/libraries/packer_variable_resource.rb:23**: Starting with Chef Infra Client 16, using `resource_name` without also using `provides` will result in resource failures. Make sure to use both `resource_name` and `provides` to change the name of the resource. You can also omit `resource_name` entirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename) ### Layout/IndentationConsistency - **/libraries/packer_builder_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_builder_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_post_processor_resource.rb:24**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_post_processor_resource.rb:24**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_provisioner_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_provisioner_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_template_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_template_resource.rb:22**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_variable_resource.rb:24**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) - **/libraries/packer_variable_resource.rb:24**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) ### Layout/IndentationWidth - **/libraries/packer_builder_resource.rb:22**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_builder_resource.rb:22**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_post_processor_resource.rb:24**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_post_processor_resource.rb:24**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_provisioner_resource.rb:22**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_provisioner_resource.rb:22**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_template_resource.rb:22**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_template_resource.rb:22**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_variable_resource.rb:24**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/packer_variable_resource.rb:24**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) ### Chef/Sharing/InvalidLicenseString - **/metadata.rb:4**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) ### Chef/RedundantCode/LongDescriptionMetadata - **/metadata.rb:6**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) ### Style/StringLiterals - **/test/fixtures/cookbooks/test/recipes/default.rb:1**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) ### Layout/SpaceAroundOperators - **/test/fixtures/cookbooks/test/recipes/default.rb:14**: Surrounding space missing for operator `=>`. (https://rubystyle.guide#spaces-operators) Signed-off-by: Cookstyle <[email protected]>
|
Closing this pull request as it has been superseded by #7, which was created with Cookstyle 7.31.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.
Style/TrailingCommaInHashLiteral
Chef/Correctness/ChefApplicationFatal
Chef/Style/CommentFormat
Chef/Deprecations/UseInlineResourcesDefined
Chef/Modernize/WhyRunSupportedTrue
Chef/Deprecations/ResourceUsesOnlyResourceName
resource_namewithout also usingprovideswill result in resource failures. Make sure to use bothresource_nameandprovidesto change the name of the resource. You can also omitresource_nameentirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename)resource_namewithout also usingprovideswill result in resource failures. Make sure to use bothresource_nameandprovidesto change the name of the resource. You can also omitresource_nameentirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename)resource_namewithout also usingprovideswill result in resource failures. Make sure to use bothresource_nameandprovidesto change the name of the resource. You can also omitresource_nameentirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename)resource_namewithout also usingprovideswill result in resource failures. Make sure to use bothresource_nameandprovidesto change the name of the resource. You can also omitresource_nameentirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename)resource_namewithout also usingprovideswill result in resource failures. Make sure to use bothresource_nameandprovidesto change the name of the resource. You can also omitresource_nameentirely if the value set matches the name Chef Infra Client automatically assigns based on COOKBOOKNAME_FILENAME. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourceusesonlyresourcename)Layout/IndentationConsistency
Layout/IndentationWidth
Chef/Sharing/InvalidLicenseString
Chef/RedundantCode/LongDescriptionMetadata
Style/StringLiterals
Layout/SpaceAroundOperators
=>. (https://rubystyle.guide#spaces-operators)Signed-off-by: Cookstyle [email protected]