Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note added to docs for proper responsiveness when relative chart parent is inside grid or flex container #11509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidAshburn
Copy link

@DavidAshburn DavidAshburn commented Sep 24, 2023

When the relative chart parent element is inside of a flex or grid container you get weird overflows on resize unless the relative chart parent has min-width set to 0

… element is a child of a flex or grid container
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile so can't review correctly but main point of critique i see now is all the style changes you did like params in a div on sperate lines or double quotes for strings. This is not in line with the rest of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants