Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] delete bounding box metadata on sparse arrays #923

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

bkmartinjr
Copy link
Contributor

Fixes #912

Remove the bounding box metadata from all SparseNDArray objects in the Census, as a work-around for single-cell-data/TileDB-SOMA#1969

@bkmartinjr bkmartinjr changed the title delete bounding box metadata on sparse arrays [builder] delete bounding box metadata on sparse arrays Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32a3333) 86.89% compared to head (44ade9b) 86.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   86.89%   86.96%   +0.07%     
==========================================
  Files          74       74              
  Lines        5518     5525       +7     
==========================================
+ Hits         4795     4805      +10     
+ Misses        723      720       -3     
Flag Coverage Δ
unittests 86.96% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkmartinjr bkmartinjr marked this pull request as ready for review January 6, 2024 01:07
Copy link
Collaborator

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr merged commit 4463f54 into main Jan 8, 2024
13 checks passed
@bkmartinjr bkmartinjr deleted the bkmartinjr/912-delete-bbox-metadata branch January 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[builder] sparse array bounding box metadata - delete after build
2 participants