refactor: clean unused imports in controllers and extend from control… #376
Conversation
…ler as base class with SchoolSessionInterface
|
@changeweb can you merge it? I want to collaborate more with the next features, we could try to implement improvements |
@lavy , Great to hear that you are eager to collaborate. I will get free time on 20th Jan and I will review these pull requests. Hope you understand. I would appreciate if you could add tests for any PRs. Thanks for the PRs BTW. |
|
Hi @changeweb in the next PRs i will add tests, in this case i didn't change so much, but i want to try to help in organize first and after that introduce some tests |
|
@lavy please address the review. |
|
Do you review it on pair? i have no time in this moment. |
| @@ -2,23 +2,20 @@ | |||
|
|
|||
| namespace App\Http\Controllers; | |||
|
|
|||
| use App\Http\Controllers\Controller; | |||
There was a problem hiding this comment.
How the Controller class will be extended if it is not imported?
I reviewed it. Please check now. |
Refactor for controllers:
I remove the unused imports on controllers and make Controller as the base class with SchoolSession, on this way we could get sessions from controllers