Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use line-delimited json for storing provenance information #24

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

algomaster99
Copy link
Member

I use jsonl for the following reasons:

  1. My learnings in collector-sahab told me that it is better performance-wise to read or write a json in batches. See Write and read the execution trace part by part ASSERT-KTH/collector-sahab#249.
    • One argument against that is that collector-sahab could do with partial output, but in this project a fingerprint must be complete.
  2. Using the standard UNIX style for storing hashes can result in parsing hell if we try to accommodate GAV coordinates. This is because two spaces separate the elements in that style " ".

@algomaster99 algomaster99 merged commit ad1182f into main Jul 24, 2023
@algomaster99 algomaster99 deleted the jsonl branch July 24, 2023 12:52
@algomaster99
Copy link
Member Author

We also incorporate GAV coordinates in fingerprint because that is our provenance information. We cannot deduce this solely from the package name in the class as there is no dependence - only a convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant