refactor(request): abstract https server into a tls server for protocol checks #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TLS.Server
instance is common for both thehttps
library and thehttp2
library,according to the NodeJS documentation. Since it is a common ancestor, we should check for
this instance instead of the specific
https
flavour.On a similar note, the
net.Server
instance is common for bothhttp
andhttp2
too,though no changes are required to ensure they're cast to the same.
See the following links: