Refactor Sessions to clarify their usage #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBSession has been renamed to HandlerSession. The following exist now: - HandlerSession: a DB session scoped to the current handler; should therefore only be used inside handlers. - ThreadSession: a DB session scoped to the current thread; should be used outside of handlers, e.g. when firing off tasks in threads, or inside of services. A special HandlerSession, with knowledge of the current user, and that verifies permissions on commit, is available as `self.Session` on the base handler. This is the *preferred way of accessing* HandlerSession. To make it easier to get hold of the current engine, the Sessions each have a `.engine` attribute: `HandlerSession.engine`. This avoids having to access the engine as `HandlerSession.session_factory.kw["bind"]`.
stefanv
force-pushed
the
session-refactor
branch
from
1bcea32
to
3fdfdda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBSession has been renamed to HandlerSession.
The following exist now:
A special HandlerSession, with knowledge of the current user, and that verifies permissions on commit, is available as
self.Sessionon the base handler. This is the preferred way of accessing HandlerSession.To make it easier to get hold of the current engine, the Sessions each have a
.engineattribute:HandlerSession.engine.This avoids having to access the engine as
HandlerSession.session_factory.kw["bind"].