Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunList: use Custom filter #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

RunList: use Custom filter #84

wants to merge 6 commits into from

Conversation

VallariAg
Copy link
Member

  • Use custom filter to show filter inputs outside the table
  • Add a button to expand/hide filter options
  • Display sort button only on hover over the column title
  • Disable column action buttons (all of it's functions can be performed with sort, filter, and show/hide column buttons on corner-right)
    Column Action button options:
    image

Output:
image

Copy link

render bot commented Aug 16, 2024

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit 9d6cacc
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/67371ad16a8a330007758881
😎 Deploy Preview https://deploy-preview-84--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VallariAg VallariAg requested a review from zmc August 16, 2024 12:48
@zmc
Copy link
Member

zmc commented Aug 16, 2024

Good start! I think this will end up being a better UI than the default. Some early feedback:

  • the new toggle button jumps around when the filters are shown/hidden
  • the old toggle button (inside the table) is still present but nonfunctional
  • the filter icon present in filtered columns is cut off; maybe it can be removed
  • I think it would be good to group filters up logically, e.g.:
    • one group for "inputs" like branch, hash, suite - also scheduled date
    • a second group for "outputs" like status and ideally job counts (like runs with >N failed jobs)

What do you think?

@VallariAg
Copy link
Member Author

Got it! All of these sound great, I'll start to work on these.

ideally job counts (like runs with >N failed jobs)

This would be harder to do right now because RunList has server side filtering. Even for "filter by username", I am working on adding username filter to paddles so we can support it in pulpito-ng. So I'll probably not include filter-by-job-counts in this PR but I can open a ticket for this because it sounds like a good idea.
I see the idea behind this grouping and it makes sense!

Another grouping that I was considering:

  1. Build info: hash, branch
  2. Run info: suite, machine_type, schedule_date
  3. Results: status, job_counts

@zmc
Copy link
Member

zmc commented Nov 14, 2024

I think these changes look good. I wonder if we might want the filter box to be just slightly more compact, and also if we should show a count of active filters on the button label so that it's apparent that there are filters active if you were to visit a URL with filters in the query parameters, e.g. https://pulpito-ng-pr-84.onrender.com/?machine_type=mira might use "Show filters (1)". What do you think?

Also - the machine type filter doesn't seem to work.

- Use custom filter to show filter inputs
  outside the table
- Add a button to expand/hide filter options
- Display sort button only on hover over the column title
- Disable column action buttons (all of it's functions
  can be performed with sort, filter, and show/hide column
  buttons)

Signed-off-by: Vallari Agrawal <[email protected]>
Show the RunList custom filter in 3 sections:
build details, run details, result details.

This commit also does the following:
1. Hides the default filter icon from table
2. Hides filter icon present in filtered columns

Signed-off-by: Vallari Agrawal <[email protected]>
Make FilterMenu more compact and turn it into
a pop-over menu instead of having it open above the table.

Signed-off-by: Vallari Agrawal <[email protected]>
- use renderTopToolbarCustomActions to add the
  filter button inside the table menu
- Show what filters are applied at top right of
  the table.

Signed-off-by: Vallari Agrawal <[email protected]>
This is to handle difference in machine_type filter in
two endpoints /node/?machine_type=xyz and /runs/machine_type/xyz

Fixes machine_type filter for RunList.

Signed-off-by: Vallari Agrawal <[email protected]>
@VallariAg
Copy link
Member Author

VallariAg commented Nov 15, 2024

@zmc thank you for the review! I've fixed the things you mentioned and improved the filter menu UI.
Render deployment here looks outdated, not sure why. Here's what the menu looks like now:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants