-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunList: use Custom filter #84
base: main
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://pulpito-ng-pr-84.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cqvkcaqj1k6c73bs7nc0. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Good start! I think this will end up being a better UI than the default. Some early feedback:
What do you think? |
Got it! All of these sound great, I'll start to work on these.
This would be harder to do right now because RunList has server side filtering. Even for "filter by username", I am working on adding username filter to paddles so we can support it in pulpito-ng. So I'll probably not include filter-by-job-counts in this PR but I can open a ticket for this because it sounds like a good idea. Another grouping that I was considering:
|
f4de7d4
to
148195e
Compare
148195e
to
de988f7
Compare
I think these changes look good. I wonder if we might want the filter box to be just slightly more compact, and also if we should show a count of active filters on the button label so that it's apparent that there are filters active if you were to visit a URL with filters in the query parameters, e.g. https://pulpito-ng-pr-84.onrender.com/?machine_type=mira might use "Show filters (1)". What do you think? Also - the machine type filter doesn't seem to work. |
- Use custom filter to show filter inputs outside the table - Add a button to expand/hide filter options - Display sort button only on hover over the column title - Disable column action buttons (all of it's functions can be performed with sort, filter, and show/hide column buttons) Signed-off-by: Vallari Agrawal <[email protected]>
Show the RunList custom filter in 3 sections: build details, run details, result details. This commit also does the following: 1. Hides the default filter icon from table 2. Hides filter icon present in filtered columns Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
Make FilterMenu more compact and turn it into a pop-over menu instead of having it open above the table. Signed-off-by: Vallari Agrawal <[email protected]>
de988f7
to
208920a
Compare
- use renderTopToolbarCustomActions to add the filter button inside the table menu - Show what filters are applied at top right of the table. Signed-off-by: Vallari Agrawal <[email protected]>
This is to handle difference in machine_type filter in two endpoints /node/?machine_type=xyz and /runs/machine_type/xyz Fixes machine_type filter for RunList. Signed-off-by: Vallari Agrawal <[email protected]>
19e4f96
to
9d6cacc
Compare
@zmc thank you for the review! I've fixed the things you mentioned and improved the filter menu UI. |
Column Action button options:
Output: