-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add rook-ceph cluster ci test #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
force-pushed
the
set-rook-ceph-cluster
branch
from
July 5, 2024 06:43
3233a38
to
936c890
Compare
subhamkrai
force-pushed
the
set-rook-ceph-cluster
branch
2 times, most recently
from
July 5, 2024 09:05
96c7815
to
c0a5553
Compare
Testing looks good @Madhu-1. Let me what else I need in this PR
|
Madhu-1
requested changes
Jul 8, 2024
subhamkrai
force-pushed
the
set-rook-ceph-cluster
branch
2 times, most recently
from
July 9, 2024 06:11
a13f98a
to
0d09bc0
Compare
subhamkrai
force-pushed
the
set-rook-ceph-cluster
branch
from
July 9, 2024 07:28
0d09bc0
to
4f776c0
Compare
Madhu-1
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits, LGTM
Signed-off-by: subhamkrai <[email protected]>
subhamkrai
force-pushed
the
set-rook-ceph-cluster
branch
from
July 9, 2024 08:04
4f776c0
to
f4a12a1
Compare
Madhu-1
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.