Replace utm with pyproj
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlodef
reviewed
May 15, 2019
rpcm/rpc_model.py
Outdated
| # azimuth is the clockwise angle with respect to the North | ||
| # of the projection of the satellite direction on the horizontal plane | ||
| # This can be computed by taking the argument of a complex number | ||
| # in a coordinate system where easting is the x axis and northing the y axis |
There was a problem hiding this comment.
I'm maybe not interpreting this correctly, but I'd say that this comment should read
# in a coordinate system where northing is the x axis and easting the y axis
rpcm/rpc_model.py
Outdated
| # of the projection of the satellite direction on the horizontal plane | ||
| # This can be computed by taking the argument of a complex number | ||
| # in a coordinate system where easting is the x axis and northing the y axis | ||
| northing, easting = satellite_direction[:2] |
There was a problem hiding this comment.
I find this misleading as the vector satellite_direction contains (utm easting, utm northing, altitude). Maybe we can swap northing, easting here and swap them again in the next line?
There was a problem hiding this comment.
Indeed I got things mixed up... Should be good now!
carlodef
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python package
utmis not very accurate (see Turbo87/utm#36), so it is preferable to replace it with the standardpyproj.Note:
pyprojhas a larger overhead thanutm, so my PR makes a call toincidence_angles()a bit slower (it goes from 20ms to 80ms in my tests). Unfortunately, I don't think we can easily benefit frompyproj's scalar ability in this case to speed things up.