Check disabled tracing URLs based on regex #1106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
jonasmiederer
requested review from
a team,
aabmass,
hectorhdzg,
lzchen and
songy23
as code owners
jonasmiederer
force-pushed
the
disable-tracing-url-regex-support
branch
from
3198fea
to
c80fb62
Compare
|
Is this change going to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the disabled tracing URLs are checked by testing whether the path starts with one of the provided excludelist paths
However if I want to exclude the root (/) from being traced, this is not possible. If an empty string is provided to
disable_tracing_url, every path is disabled as every string starts with an empty string.A check using regex would solve the problem and also make it more flexible.