feat: initial pyroscope integration #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
changed the title
evan-forbes
changed the title
|
Here's a pic of this running on one of the mocha validators |
|
why the linter is complaining about
now is beyond me. |
evan-forbes
commented
Aug 2, 2023
Comment on lines
-91
to
+92
| //nolint:staticcheck // SA1019 Existing use of deprecated but supported dial option. | ||
| conn, err := grpc.Dial(cli.addr, grpc.WithInsecure(), grpc.WithContextDialer(dialerFunc)) | ||
| conn, err := grpc.Dial(cli.addr, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialerFunc)) |
There was a problem hiding this comment.
I do not know why the linter started complaining for this here, but this seemed like the best solution
rootulp
previously approved these changes
Aug 2, 2023
Comment on lines
-91
to
+92
| //nolint:staticcheck // SA1019 Existing use of deprecated but supported dial option. | ||
| conn, err := grpc.Dial(cli.addr, grpc.WithInsecure(), grpc.WithContextDialer(dialerFunc)) | ||
| conn, err := grpc.Dial(cli.addr, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(dialerFunc)) |
Co-authored-by: Rootul P <[email protected]>
rootulp
previously approved these changes
Aug 3, 2023
…elestia-core into evan/pyroscope-integration
|
ok apologies, had a last minute addition after the first round of reviews where I added the ability to specify which profiles to run in the config, along with changing the defaults see c9794fa its identical to the rest of the additions to the config |
rootulp
approved these changes
Aug 3, 2023
staheri14
approved these changes
Aug 3, 2023
|
@evan-forbes can you add some documentation here. I would like to be able to run this |
evan-forbes
added a commit
that referenced
this pull request
Sep 28, 2023
leaving as a draft and WIP until I test this out more. not ready for review closes #1004 --------- Co-authored-by: Rootul P <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
leaving as a draft and WIP until I test this out more. not ready for review
closes #1004